Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NUOPEN-6][Shared dev] Daily rate with fixed start time: create a reservation #4863

Merged
merged 7 commits into from
Dec 23, 2024

Conversation

joaquinco
Copy link
Collaborator

@joaquinco joaquinco commented Dec 18, 2024

Note

  • Add Instrument#fixed_start_time boolean to tell if daily reservations should start at the beginning of the day
  • Add system tests for instrument setting the attribute and reservation creation
  • Hide start and end times from reservation form
  • Don't render Start time availability table if fixed_start_time is on

The form component containing times and duration looks weird as it is because there's a lot of empty spacing. I will work on this after wrapping up the most important changes

Upcomming PRs will cover schedule rules, editing and moving reservations

Screenshots

Captura de pantalla 2024-12-18 a la(s) 11 10 05

@joaquinco joaquinco force-pushed the 162526/daily-rate-fixed-start-create-reservation branch from b3a2103 to bf3dbfa Compare December 18, 2024 13:40
@joaquinco joaquinco marked this pull request as ready for review December 18, 2024 14:15
Copy link
Collaborator

@LeticiaErrandonea LeticiaErrandonea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the name should be different. We have the help text in the form but the label is "Fixed Start Time" which is not so self explanatory to me. Is the same for the field in the DB. Maybe something like "start_reservations_at_midnight"?

@joaquinco
Copy link
Collaborator Author

@LeticiaErrandonea What about reservation_start_time_disabled or just start_time_disabled?

Copy link
Collaborator

@LeticiaErrandonea LeticiaErrandonea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think unrelated specs are failing

@joaquinco joaquinco merged commit 15e2efd into master Dec 23, 2024
3 checks passed
@joaquinco joaquinco deleted the 162526/daily-rate-fixed-start-create-reservation branch December 23, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants