Image and link methods #625
Conversation
Conflicts: src/wymeditor/core.js src/wymeditor/editor/base.js src/wymeditor/editor/webkit.js
Conflicts: src/wymeditor/core.js
Conflicts: src/test/unit/test.js
Conflicts: src/test/unit/index.html
Conflicts: src/wymeditor/editor/base.js
| } | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
This was moved to a dedicated images.js test file.
|
This releases some pressure from the #512 PR. |
|
|
||
| module("images", {setup: prepareUnitTestModule}); | ||
|
|
||
| test("Image insertion in a paragraph", function () { |
There was a problem hiding this comment.
@winhamwr can weigh in on this, but what do think of having a verb and an implied boolean outcome in the test name, e.g. "Can insert image into a paragraph"?
There was a problem hiding this comment.
I prefer the verb and boolean name. "Image insertion in a paragraph" is a bit ambiguous. It could be testing that you can't insert an image or that something specific happens when you do the insert.
There was a problem hiding this comment.
Thank you. "Inserts image in a paragraph".
|
|
||
| module("links", {setup: prepareUnitTestModule}); | ||
|
|
||
| test("Insert link with some attributes.", function () { |
There was a problem hiding this comment.
Inserting link with attributes succeeds
There was a problem hiding this comment.
"Inserts link with attributes".
|
Looks like there are some test name improvements to be made and some variable name cleanup. Looks good to me, once those are done. |
|
I'm not sure how we got to this, but some comments by @michaelgzoller in the PR are about changes that seem to be already merge. Probably from another PR, which was merged into this. Since it is about test and variable names and it is already merged, I'll go ahead and merge this and fix these names in |
|
I updated these test names in |
Depends on #627.