Skip to content
This repository has been archived by the owner on Apr 2, 2021. It is now read-only.

Do not enable inline table editing in gecko #647

Merged
merged 4 commits into from
Dec 18, 2014

Conversation

mightyiam
Copy link
Contributor

No description provided.

@@ -169,6 +169,7 @@ WYMeditor.WymClassGecko.prototype._designModeQuirks = function () {
try {
wym._doc.execCommand("styleWithCSS", '', false);
wym._doc.execCommand("enableObjectResizing", false, true);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description of this can be found here. Here is a screenshot of what this does:
screenshot from 2014-12-17 22 01 25
The attributes do indeed pass through the parser.

Do we want this? Other browsers don't have this feature, or have it turned off. I just checked and Chrome doesn't seem to have this.

I can see how this can be useful with images in some cases, but this really should be the role of module specific for this purpose, with tests and consistent cross–browser behavior.

If we turn this off now, will some users be upset?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@winhamwr this is a different feature. It affects tables as well. Do we want this off, as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We want them both off.

@mightyiam mightyiam changed the title Do not enable object resizing in gecko Do not enable inline table editing in gecko Dec 17, 2014
@winhamwr
Copy link
Member

We used to automatically disable this feature. At some point, we must have regressed. We definitely want to disable this.

Gecko (Firefox) has a feature of editing tables by mouse dragging,
that is considered unhelpful.
It was previously disabled for a while and it was found to be enabled now.
So it is now disabled again.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@winhamwr better entry?

mightyiam added a commit that referenced this pull request Dec 18, 2014
Do not enable inline table editing in gecko
@mightyiam mightyiam merged commit fe997e8 into master Dec 18, 2014
@mightyiam mightyiam deleted the geckoDisableObjectResizing branch December 18, 2014 12:11
@mightyiam
Copy link
Contributor Author

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants