-
Notifications
You must be signed in to change notification settings - Fork 115
Do not enable inline table editing in gecko #647
Conversation
@@ -169,6 +169,7 @@ WYMeditor.WymClassGecko.prototype._designModeQuirks = function () { | |||
try { | |||
wym._doc.execCommand("styleWithCSS", '', false); | |||
wym._doc.execCommand("enableObjectResizing", false, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description of this can be found here. Here is a screenshot of what this does:
The attributes do indeed pass through the parser.
Do we want this? Other browsers don't have this feature, or have it turned off. I just checked and Chrome doesn't seem to have this.
I can see how this can be useful with images in some cases, but this really should be the role of module specific for this purpose, with tests and consistent cross–browser behavior.
If we turn this off now, will some users be upset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@winhamwr this is a different feature. It affects tables as well. Do we want this off, as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. We want them both off.
We used to automatically disable this feature. At some point, we must have regressed. We definitely want to disable this. |
Gecko (Firefox) has a feature of editing tables by mouse dragging, | ||
that is considered unhelpful. | ||
It was previously disabled for a while and it was found to be enabled now. | ||
So it is now disabled again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@winhamwr better entry?
Do not enable inline table editing in gecko
Thank you! |
No description provided.