Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade underlaying library #13

Merged
merged 11 commits into from
Apr 11, 2020
Merged

Upgrade underlaying library #13

merged 11 commits into from
Apr 11, 2020

Conversation

jihchi
Copy link
Contributor

@jihchi jihchi commented Apr 5, 2020 •
edited
Loading

  • Upgrade bs-dom-testing-library to latest version
  • Upgrade @testing-library/react to latest version
  • Add support for queries
    • ByLabelText
      • getBy, getAllBy, queryBy, queryAllBy, findBy and findAllBy
    • ByPlaceholderText
      • getBy, getAllBy, queryBy, queryAllBy, findBy and findAllBy
    • ByText
      • getBy, getAllBy, queryBy, queryAllBy, findBy and findAllBy
    • ByAltText
      • getBy, getAllBy, queryBy, queryAllBy, findBy and findAllBy
    • ByTitle
      • getBy, getAllBy, queryBy, queryAllBy, findBy and findAllBy
    • ByDisplayValue
      • getBy, getAllBy, queryBy, queryAllBy, findBy and findAllBy
    • ByRole
      • getBy, getAllBy, queryBy, queryAllBy, findBy and findAllBy
    • ByTestId
      • getBy, getAllBy, queryBy, queryAllBy, findBy and findAllBy
  • This implementation is based on [@bs.send.pipe: renderResult]which is different from current one and Fix queries so they are bound to baseElement #7
  • This PR should also fix How to use findBy* functions? #12

@coveralls
Copy link

coveralls commented Apr 5, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 28

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+21.0%) to 99.123%
Totals Coverage Status
Change from base Build 18: 21.0%
Covered Lines: 112
Relevant Lines: 112
💛 - Coveralls

@jihchi jihchi changed the title WIP: Upgrade underlaying library Upgrade underlaying library Apr 10, 2020
@jihchi
Copy link
Contributor Author

jihchi commented Apr 10, 2020

Hi @wyze , I have finished this PR, could you please review it when you have got the time?

wyze
wyze approved these changes Apr 11, 2020
View reviewed changes
Copy link
Owner

@wyze wyze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work again!

@wyze wyze merged commit 08221ff into wyze:master Apr 11, 2020
@jihchi jihchi deleted the upgrade_underlaying_library branch April 11, 2020 02:58
@cironunes
Copy link

This is great. Thanks, @jihchi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyze wyze wyze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to use findBy* functions?
4 participants
@jihchi @coveralls @cironunes @wyze