Updates has_metadata to has_donor_metadata #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerekFurstPitt
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
This looks correct. Also of note, after some discussion about what information the people using this data-ingest-board want to see, it became clear that having a field involving metadata at the dataset level would also be useful. So in addition to this has_donor_metadata field, I've also added in the backend a has_dataset_metadata property (to be more clear with the naming this time). So at some point, a new column can be created on the ui side (probably right beneath this entry) to accommodate for that.
yuanzhou
approved these changes
Nov 21, 2023
This was referenced Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the has_metadata value for the dataset Table to use has_donor_metadata