Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libpitt/247 board msg #250

Open
wants to merge 4 commits into
base: dev-integrate
Choose a base branch
from
Open

Libpitt/247 board msg #250

wants to merge 4 commits into from

Conversation

libpitt
Copy link
Contributor

@libpitt libpitt commented Jan 6, 2025

Change log:

  1. Add alert if there's no cache ready

@yuanzhou
Copy link
Contributor

yuanzhou commented Jan 9, 2025

@libpitt @maxsibilla does this PR require any backend support?

@libpitt
Copy link
Contributor Author

libpitt commented Jan 9, 2025

@libpitt @maxsibilla does this PR require any backend support?

I believe @tjmadonna added some changes which will return a 202 while it is caching. Please confirm.

@maxsibilla
Copy link
Contributor

@yuanzhou Yes this requires an update to the Ingest API in both /data-status endpoints. You will need to return a 202 if the caching has not completed AND there is no current cache

@tjmadonna
Copy link
Contributor

tjmadonna commented Jan 9, 2025

The endpoints will return a 202 if still caching

{
  "message": "Uploads data-status is currently being cached"
}

@yuanzhou
Copy link
Contributor

yuanzhou commented Jan 9, 2025

Thanks @libpitt @maxsibilla @tjmadonna, I'll have to add a new card for this to be implemented in HuBMAP ingest-api. In the meanwhile, if you've already done the work please feel free to merge this PR and proceed on the SenNet DEV testing so we don't hold off your progress. A link to the PR of your work is also appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants