Deprecate validation_application_context #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: sources endpoint does not return source information if the sourc…
…_application_context, which is handled properly in functions in the hs-ontology-api repository.
yuanzhou
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates the remanining functionality that should have been moved to hs-ontology-api when it was created as part of the refactoring of ubkg-api.
Validation:
hs-ontology-api calls ubkg-api as a library/package.
This was tested with a development branch of hs-ontology-api that pointed to the following instance of ubkg-api:
git+https://github.com/x-atlas-consortia/ubkg-api.git@simmons/deprecate_validate_application_context
Test scripts ran as expected.
ADDITIONAL TASKS:
Once merged,