-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements and bug fixes #165
Conversation
…date_application_context Deprecated validate.py. This file contains only the function validate…
…ired parameter for sources in YAML files
…ed preferred terms.
@AlanSimmons How do you plan to test out these changes? Considering the new https://github.com/x-atlas-consortia/data-distillery-api |
@yuanzhou I tested all of these changes in my local development instance of ubkg-api. The current data-distillery-api has no endpoints of its own, and is essentially a wrapper for the ubkg-api library. The hs-ontology-api also uses the ubkg-api PyPI. Because the ubkg-api will only be a library, conservative testing of changes to the ubkg-api would actually involve executing a ubkg-api endpoint in a child API. The safest way to do this would be to modify the requirements.txt for the test deployment of a child api so that it points to the test branch of the ubkg-api instead of the PyPi package. Ugh. This seems unnecessarily complicated. It might make more sense to deploy a test instance of just the ubkg-api that would not be promoted to production. We could test the ubkg-api endpoint in situ, and then test it again in a child API after ubkg-api is recompiled. Who knew that this was going to get this complicated? |
@AlanSimmons I can build hs-ontology-api against |
@yuanzhou Yes. These changes were to existing endpoints, not new ones. |
See linked issues for descriptions of enhancements or bug fixes addressed in this PR.