Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements and bug fixes #165

Merged
merged 6 commits into from
Jan 10, 2025
Merged

Enhancements and bug fixes #165

merged 6 commits into from
Jan 10, 2025

Conversation

AlanSimmons
Copy link
Collaborator

@AlanSimmons AlanSimmons commented Jan 3, 2025

See linked issues for descriptions of enhancements or bug fixes addressed in this PR.

@yuanzhou
Copy link
Contributor

yuanzhou commented Jan 9, 2025

@AlanSimmons How do you plan to test out these changes? Considering the new https://github.com/x-atlas-consortia/data-distillery-api

@AlanSimmons
Copy link
Collaborator Author

@yuanzhou I tested all of these changes in my local development instance of ubkg-api.

The current data-distillery-api has no endpoints of its own, and is essentially a wrapper for the ubkg-api library. The hs-ontology-api also uses the ubkg-api PyPI.

Because the ubkg-api will only be a library, conservative testing of changes to the ubkg-api would actually involve executing a ubkg-api endpoint in a child API. The safest way to do this would be to modify the requirements.txt for the test deployment of a child api so that it points to the test branch of the ubkg-api instead of the PyPi package. Ugh. This seems unnecessarily complicated.

It might make more sense to deploy a test instance of just the ubkg-api that would not be promoted to production. We could test the ubkg-api endpoint in situ, and then test it again in a child API after ubkg-api is recompiled.

Who knew that this was going to get this complicated?

@yuanzhou
Copy link
Contributor

yuanzhou commented Jan 9, 2025

@AlanSimmons I can build hs-ontology-api against dev-integrate branch and deploy on DEV for you to test. One thing I'm not certain is did we expose all the ubkg-api endpoints via hs-ontology-api Gateway to cover the changes made in this PR?

@AlanSimmons
Copy link
Collaborator Author

@yuanzhou Yes. These changes were to existing endpoints, not new ones.

@yuanzhou yuanzhou merged commit 9305e8b into dev-integrate Jan 10, 2025
1 check passed
@yuanzhou yuanzhou mentioned this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment