Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UP my solution #186

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions numpy_questions.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,26 @@ def max_index(X):
i = 0
j = 0

# TODO
if X is None:
raise ValueError("Input is None")

if not isinstance(X, np.ndarray):
raise ValueError("Input is not a valid numpy array")

if len(X.shape) != 2:
raise ValueError("Input shape is not 2D")

max_val = X[i, j]

for row_idx in range(X.shape[0]):
for col_idx in range(X.shape[1]):
if X[row_idx, col_idx] > max_val:
i = row_idx
j = col_idx
max_val = X[row_idx, col_idx]

# idx = np.argmax(X)
# (i,j) = np.unravel_index(idx, X.shape)

return i, j

Expand All @@ -64,4 +83,9 @@ def wallis_product(n_terms):
"""
# XXX : The n_terms is an int that corresponds to the number of
# terms in the product. For example 10000.
return 0.
pi_approx = 1

for i in range(n_terms):
pi_approx *= (4 * ((i + 1) ** 2)/(4 * ((i + 1) ** 2) - 1))

return 2*pi_approx
Loading