-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag for JS enhanced file upload #548
Open
DavidBiddle
wants to merge
2
commits into
x-govuk:main
Choose a base branch
from
DavidBiddle:add-file-upload-javascript-flag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add flag for JS enhanced file upload #548
DavidBiddle
wants to merge
2
commits into
x-govuk:main
from
DavidBiddle:add-file-upload-javascript-flag
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for govuk-form-builder pending review.Visit the deploys page to approve it
|
DavidBiddle
added a commit
to alphagov/forms-runner
that referenced
this pull request
Mar 4, 2025
Relies on govuk_design_system_formbuilder gem merging this PR: x-govuk/govuk-form-builder#548
DavidBiddle
added a commit
to alphagov/forms-runner
that referenced
this pull request
Mar 4, 2025
Relies on govuk_design_system_formbuilder gem merging this PR: x-govuk/govuk-form-builder#548
Looks great thank you @DavidBiddle - Looking to get the updated versions out this week. I suspect the builds will fail until rebased as there were problems with Rails 7.0. I started playing around with this in draft form too before I noticed your PR. Closed mine in favour of yours. |
peteryates
reviewed
Mar 10, 2025
Co-authored-by: Peter Yates <peter.yates@graphia.co.uk>
2a8579a
to
a4aaa0a
Compare
@peteryates thanks for the review! Have accepted your suggestion and rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of govuk-frontend (v5.9.0) includes a new JS-enhanced version of the file upload component.
The nunjucks macro has a
javascript
flag for enabling this:which inserts a div with a class and data attribute around the input element:
This PR adds a new javascript flag to the govuk_file_field to accomplish the same thing.