Fix behavior to disable check for manipulated hash calculations. Closes

#284.
x-stream · Dec 29, 2022 · 937e15f · 937e15f
1 parent 28e4e20
commit 937e15f
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/xstream/src/java/com/thoughtworks/xstream/XStream.java b/xstream/src/java/com/thoughtworks/xstream/XStream.java
@@ -1184,7 +1184,7 @@ public void setMarshallingStrategy(final MarshallingStrategy marshallingStrategy
      * Set time limit for adding elements to collections or maps.
      * 
      * Manipulated content may be used to create recursive hash code calculations or sort operations. An
-     * {@link InputManipulationException} is thrown, it the summed up time to add elements to collections or maps
+     * {@link InputManipulationException} is thrown, if the summed up time to add elements to collections or maps
      * exceeds the provided limit.
      * 
      * Note, that the time to add an individual element is calculated in seconds, not milliseconds. However, attacks
@@ -1408,7 +1408,7 @@ public <T> T unmarshal(final HierarchicalStreamReader reader, final T root) {
      */
     public <T> T unmarshal(final HierarchicalStreamReader reader, final T root, DataHolder dataHolder) {
         try {
-            if (collectionUpdateLimit >= 0) {
+            if (collectionUpdateLimit > 0) {
                 if (dataHolder == null) {
                     dataHolder = new MapBackedDataHolder();
                 }
@@ -2105,7 +2105,7 @@ public ObjectInputStream createObjectInputStream(final HierarchicalStreamReader
      */
     public ObjectInputStream createObjectInputStream(final HierarchicalStreamReader reader, DataHolder dataHolder)
             throws IOException {
-        if (collectionUpdateLimit >= 0) {
+        if (collectionUpdateLimit > 0) {
             if (dataHolder == null) {
                 dataHolder = new MapBackedDataHolder();
             }