Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer reflective access to Java core modules (1.4) #218

Closed
wants to merge 1 commit into from

Conversation

famod
Copy link
Contributor

@famod famod commented Aug 12, 2020

Backport of 3cec78d as discussed here: #216 (comment)

Relates to #101 and quarkusio/quarkus#10303 (comment)

}
getName = method;
}
private static final Map instanceMaps = Collections.synchronizedMap(new HashMap());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semantically, a synchronized map is (of course) not the same as ConcurrentHashMap with .computeIfAbesent() (like in master) but it should be sufficient to prevent illegal concurrent access.
The drop in efficiency should be tolerable.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 80.326% when pulling fec0d0f on famod:defer-reflective-access-1.4 into 6ec68c4 on x-stream:v-1.4.x.

@joehni joehni self-assigned this Aug 12, 2020
@joehni joehni added this to the 1.4.x milestone Aug 12, 2020
@joehni
Copy link
Member

joehni commented Aug 29, 2020

Merged. Thanks for contribution.

@joehni joehni closed this Aug 29, 2020
@joehni joehni modified the milestones: 1.4.x, 1.4.13 Sep 6, 2020
@famod
Copy link
Contributor Author

famod commented Sep 7, 2020

@joehni Thank you very much for releasing 1.4.13 with this workaround!

@joehni
Copy link
Member

joehni commented Sep 7, 2020

Thanks for your contribution. Now that it is available on Central, I can finally send the announcement... ;-)

gsmet pushed a commit to gsmet/quarkus that referenced this pull request Sep 8, 2020
Fixes quarkusio#10303 for some cases when using JUnit5 ParameterResolver.

Includes x-stream/xstream#218 that tries to avoid such warnings at XStream creation time.

Also adds xstream to dependabot. Comment regardings optaplanner was outdated.
@famod famod deleted the defer-reflective-access-1.4 branch November 5, 2020 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants