Skip to content

Latest commit

 

History

History
23 lines (19 loc) · 834 Bytes

Remove stale comments.md

File metadata and controls

23 lines (19 loc) · 834 Bytes

Remove inline comments that suggest the two uint256 values DAOfiV1Pair.reserveBase and DAOfiV1Pair.reserveQuote are stored in the same storage slot. This is likely a carryover from the UniswapV2Pair contract, in which reserve0, reserve1, and blockTimestampLast are packed into a single storage slot.

Recommendation:

Remove stale comments


Slide Screenshot

108.jpg


Slide Text

  • ConsenSys Audit DAOfi Finding 3.1
  • Documentation
  • Stale Comments about Storage Slots
  • Remove Stale Comments

References


Tags