Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some proposed enhancements #3

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

michaelblight
Copy link

Hello Alex - not sure if you're interested in other contributors, but I wanted a couple of options myself, so thought I'd give it a bash.

The changes I'm proposing are:

  1. Allowing log level to be optional by including a "(none)" option.
  2. Allowing msg.topic to be included in the log if present. This is set up in the log-config page when the log style is plain text. This defaults to unselected for backward compatibility.
  3. Allowing the source (eg. msg.payload) to be optional. This is also set up in the log-config page when the log style is plain text. I think this should be backwardly compatible, because it's defaulting to selected.
  4. If both topic and source are included, they're separated by a ":".

What do you think?

@michaelblight
Copy link
Author

I've also added the ability to rotate the log on demand by setting msg.rotateNow to true. I'm doing this at midnight to get daily log files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants