Fixing IfcBooleanClippingResult conversion into XbimSolidSet #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge xBimTeam Develop
Second operand has never been added to difference build chain. Refactored IfcBooleanClippingResult to XbimSolidSet conversion.
This was referenced Mar 27, 2019
guenter1holzeder
added a commit
to OrcaIfc/XbimGeometry
that referenced
this pull request
Apr 3, 2019
…esult constellation. The new implementation fixes all constellations of the first and second operand as proved with the extended UnitTest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #158 (Wrong geometry processing with IfcBooleanClippingResult).
The second operand of the root clipping request has never been investigated. I've did some refactoring and dropped some (useless) code.