Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cftime to avoid out of bounds datetime when decoding non-CF time coordinates #283

Merged
merged 13 commits into from
Aug 2, 2022
Merged

Use cftime to avoid out of bounds datetime when decoding non-CF time coordinates #283

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3050a8d
initial solution for #278
pochedls Jul 26, 2022
a681787
PR review refactor
tomvothecoder Jul 28, 2022
4c33bf9
Consider calendar type when decoding non-Cf time
tomvothecoder Jul 28, 2022
ba66aef
Update xcdat/dataset.py
tomvothecoder Jul 28, 2022
4d01344
Update xcdat/dataset.py
tomvothecoder Jul 28, 2022
4fb0656
Fix datetime reference
tomvothecoder Jul 28, 2022
e0760bd
return more specific cftime datetime types
pochedls Jul 29, 2022
597ae30
removing extraneous calendar specification
pochedls Jul 29, 2022
3e9d09c
Refactor using xarray methods
tomvothecoder Aug 1, 2022
beb2a07
Update docstrings and silence logger warnings in tests
tomvothecoder Aug 1, 2022
37939d2
Fix Timestamp limitation from dtype
tomvothecoder Aug 2, 2022
9dfaa79
Add space in logger warning
tomvothecoder Aug 2, 2022
c0d8703
Merge branch 'main' into bugfix/282-OutOfBoundsDatetime
pochedls Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,10 @@ repos:
- id: mypy
args: ["--config=setup.cfg"]
additional_dependencies:
[dask==2022.6.1, numpy==1.23.0, pandas==1.4.3, xarray==2022.3.0]
[
dask==2022.6.1,
numpy==1.22.4,
pandas==1.4.3,
xarray==2022.3.0,
types-python-dateutil==2.8.2,
tomvothecoder marked this conversation as resolved.
Show resolved Hide resolved
]
3 changes: 2 additions & 1 deletion conda-env/dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ dependencies:
- numpy=1.22.4
- pandas=1.4.3
- xarray=2022.3.0
- xesmf=0.6.3
- python-dateutil=2.8.2
- types-python-dateutil=2.8.19
tomvothecoder marked this conversation as resolved.
Show resolved Hide resolved
# Quality Assurance
# ==================
# If versions are updated, also update 'rev' in `.pre-commit.config.yaml`
Expand Down
Loading