Issue mozilla#125 - Improve empty variable strings handling

Leave "${Something}" untouched if nightly.variables doesn't have such property, and let it be "Undefined" if it's a known variable, but currently unavailable. For example in the "${Changeset}" case, when application.ini doesn't always contain a "SourceStamp" key.
xabolcs · Apr 8, 2013 · 8d81f70 · whimboo · Apr 9, 2013 · xabolcs
1 parent 3cf292d
commit 8d81f70
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/extension/chrome/content/nightly.js b/extension/chrome/content/nightly.js
@@ -142,7 +142,16 @@ getStoredItem: function(type, name) {
     return nightly.preferences.getCharPref(type+"."+name);
   }
   catch (e) {}
-  return nightly[type][name];
+
+  if (nightly[type].hasOwnProperty(name)) {
+    varvalue = nightly[type][name];
+    if (varvalue === undefined || varvalue === null) {
+      varvalue = nightly.getString("nightly.variables.nullvalue");
+    }
+    return varvalue;
+  }
+
+  return undefined;
 },
 
 getVariable: function(name) {

diff --git a/extension/chrome/content/titlebar/customize.js b/extension/chrome/content/titlebar/customize.js
@@ -118,10 +118,6 @@ addVariable: function(name)
     text="";
   }
   var value = paneTitle.nightly.getVariable(name);
-  if (value==null)
-  {
-    value="Undefined";
-  }
   paneTitle.variables.push({variable: "${"+name+"}", description: text, value: value});
 },
 

diff --git a/extension/chrome/locale/en-US/nightly.properties b/extension/chrome/locale/en-US/nightly.properties
@@ -8,3 +8,4 @@ nightly.noextensions.message=No extensions were found.
 nightly.restart.message=Addon compatibility has changed, restart to affect currently installed addons
 nightly.restart.label=Restart
 nightly.restart.accesskey=R
+nightly.variables.nullvalue=Undefined