-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raspberry pi check for Freeswitch 1.7 #23
base: master
Are you sure you want to change the base?
Conversation
@@ -10,8 +10,11 @@ PROC?=$(shell uname -m) | |||
|
|||
CC=gcc | |||
CFLAGS=-fPIC -O3 -fomit-frame-pointer -fno-exceptions -Wall -std=c99 -pedantic | |||
MODEL=$(cat /proc/device-tree/model) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will fail on standard system and no error handling is done
ifeq (${PROC},x86_64) | ||
CFLAGS+=-m64 -mtune=generic | ||
else ifneq (,$(findstring "Raspberry Pi", $(MODEL))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would check the PROC var, or at least leverage on uname:
pi@raspberrypi:~ $ uname -a
Linux raspberrypi 4.1.19-v7+ #858 SMP Tue Mar 15 15:56:00 GMT 2016 armv7l GNU/Linux
I don't have a rpi now to check what uname -m
outputs (basically the value of $PROC), you may want to look at it.
Right now (without your mods), what happens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gcc: error: unrecognized argument in option ‘-march=i686’
gcc: error: unrecognized command line option ‘-m32’
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok , uname -m
return armv7l
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, so please update the PR (and rebase it to have a single commit) and I'll be happy to check it again and merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty much a duplicate of my pr #19
Adding that specific raspberry pi code is not needed afaik.
Just need to eliminate the usage of m32 etc from non x86 based architectures like arm etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adds armv7 to compile on 32bit Raspian OS.
I'm not very sure how to properly check in bash but added an
ifneq
statement, do suggest but I'm just offering a makeshift solution for now.