-
Notifications
You must be signed in to change notification settings - Fork 72
updated Facebook.Android to 11.2.0 #214
updated Facebook.Android to 11.2.0 #214
Conversation
It's not deprecated by facebook
# Conflicts: # Facebook.Android/source/facebook-places/transforms/Metadata-Names.xml
@thisisthekap if the PR is not merged in like a week or two can you please release Nuget from forked repo? |
@pmahend1 I am not going to publish a facebook sdk nuget to nuget.org, because I
If you need the changes right away, feel free to build a custom nuget yourself using For the sake of completeness: I did the changes at best effort, but without any warranty. |
@jpobst @moljac @Redth @mattleibow Are you able to provide an ETA when this PR is going to be looked into? This PR consists of many changes, because I had to close #199 because I updated the SDK to 11.2.0, and the old PR didn't get any attention anymore. If the old PR should be completed first to have a small changeset of unreviewed changes: Of course we could do that as well. |
For anyone that isn't aware why this PR is important, Facebook have mandated and will shortly enforce the usage of (minimum) v8.20.0 of the Facebook Android SDK when using Facebook Login. |
In case this PR is not addressed ASAP, I guess we are left with option of creating our own nuget or someone creating another repo thats regularly maintained. |
This is the approach I have taken for now. For anyone that needs to do the same, here are the steps I took.
This means the package will be flagged as pre-release, and will hopefully be superseded by the official version if/when it is published.
|
Because of message, that pmahend1 mentioned 4 days ago about deprecating webview: Currently in Xamarin Forms app I am using Xamarin.Facebook.Android library version 5.11.2 and LoginBehavior = LoginBehavior.NativeWithFallback. Following to documentation: "NATIVE_WITH_FALLBACK I am not using embedded browser. So after 5th October will user be able to log in to my application using Facebook or not? If update to library version 8.2.0 is a duty, when can we expect update of Xamarin.Facebook.Android on nuget? I think a lot of people will be intered in. We have one month to go. |
@dev-xam The situation is even worse: Once Facebook drops the support for old login variants, all the app installations out there have to be updated to the latest version of your app to avoid issues for existing app installations. So you might be forced to do a mandatory app upgrade. |
Currently Xamarin.Facebook.Android available on NuGet is version 7.1.0. Will there be any update to at least version 8.2.0 soon? |
Azure Pipelines failed to run 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi @moljac, Do you think this will be available for testing before the FB deadline of Oct 5th? Just trying to figure out if I should plan for an alternative solution. Many thanks 🙏 |
@moljac could you give updates please |
Commenter does not have sufficient privileges for PR 214 in repo xamarin/FacebookComponents |
Deadline passed. Any update how log it will take?
If your app is built to target Android 11 (API level 30) and your users are on Android 11, alternative non-webview login mechanisms provided by the SDK will not work unless you upgrade to 8.2.0 or later. |
Build seems to be using .Net 6 , is that why there are these build failures? Since .Net 6 and MSBuild/Visual Studio 2022 are still in preview changing the pipeline might help. |
No it is not |
If they are running fine for Windows task in the pipeline then should work fine with Mac agent build too right? |
Anyone know any alternate bindings for Facebook SDK? As of today our users can't log in using Facebook login. Any temporary workaround? |
@waheez build by instruction from fork of Molijak |
You can request for an extension AFAIK. |
Hi @pmahend1 FB said I can contact them for the extension however, they did not mention the exact contact point. The possible one I found out is https://developers.facebook.com/incident/report/ but not sure if it is the right contact point. |
I am trying to build it from fork but got an Install Referrer conflict error. I have Adjust SDK, which embedded Install Referrer. Are there any suggestions how I can resolve this conflict? |
@BradKwon I fixed that issue for the Adjust SDK in adjust/xamarin_sdk#33. Unfortunately, they refused to accept this change. To fix it for your individual project, you will have to do a fork of the adjust sdk, remove the native reference to installreferrer, and add the same nuget as referenced by the facebook bindings. |
@thisisthekap Thanks for your fast feedback! I have gone through the conversation you had with Adjust. So I see that as a user who uses both Adjust & Facebook should choose either touching Adjust SDK or Facebook SDK to resolve Install Referrer issue. I am not sure if it is possible with Facebook SDK like Adjust SDK though. |
To my point of view, Adjust should reference a nuget package instead of referencing a native library. It is considered to be best practive to use nuget references when creating xamarin bindings. This is mainly to avoid dependency issues like the one you are currently facing.
… On 07.10.2021, at 11:11, Brad Kwon ***@***.***> wrote:
@thisisthekap <https://github.com/thisisthekap> Thanks for your fast feedback! I have went through the conversation you had with Adjust. So I see that as a user who uses both Adjust & Facebook should choose either touching Adjust SDK or Facebook SDK to resolve Install Referrer. I am not sure if it is possible with Facebook SDK like Adjust SDK though.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#214 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACFG2ZS52LP7D5YOAY33BZLUFVP3FANCNFSM5C2EOKYA>.
|
I dont either. On same boat as you. |
Hi @moljac As this PR is merged... when can we expect the nuget package to be updated? Thanks. |
Small update from my previous comment regarding Adjust & FB collision: As FB login functionality was an optional in my app and FB has several issues recently, I touched FB SDK for Xamarin to remove Install Referrer dependency from Core project and the problem was solved. I have released it and I am able to login even on Android 11 now. In my opinion, it would be the best if Adjust decoupled Install Referrer and both use one common Install Referrer Nuget. Therefore, I have written my concern to Adjust GitHub. I hope there will be a constructive discussion sooner or later. |
The users of my application cannot log in to facebook, how do I solve it? |
Change target android version from 11 to 10 and send app for review, as soon as possible, because Google will stop accepting apps with target set to 10 soon. Second option is to create custom library from newest pull request (11.2.0), build cake etc. as mentioned above. I did that and users can log in to my app easily and target android version is 11. |
I don't know how to create that from the cake |
@angelru if you are on a Mac:
You'll see nupkg files in the
|
You meant to say Change target android version to 11 from 10 , not the other way around I think. |
i'm on windows |
Fixes #213
Updates the facebook android sdk to 11.2.0.
This PR includes the changed made in the PRs #193 and #195 which I created some time ago. As these PRs were not merged by now, their changes are included in this PR, and closed.