Skip to content
This repository was archived by the owner on Nov 6, 2024. It is now read-only.

Conversation

@jpobst
Copy link
Contributor

@jpobst jpobst commented Nov 1, 2022

Import Xamarin.Android.Google.BillingClient* packages from XamarinComponents so they will be supported.

Xamarin.Android.Google.BillingClient:

image

Note this now uses the GooglePlayServices template, which is correct, as this package is licensed under the Android SDK License, it is not Apache, and thus we should not be including the .aar in the NuGet like we previously were.

Note also that we are still including the .aar in the NuGet, which is incorrect, however this is a bug in our GPS template which is currently doing this for all packages and needs to be fixed separately.

Xamarin.Android.Google.BillingClient.Ktx:

image

Same notes apply for this package.

@jpobst jpobst force-pushed the import-billing-client branch from 232faff to 36b359e Compare November 1, 2022 18:20
@jpobst jpobst force-pushed the import-billing-client branch from 36b359e to f4aa3c5 Compare November 15, 2022 15:12
@jpobst jpobst marked this pull request as ready for review November 15, 2022 19:37
@jpobst jpobst requested a review from moljac November 15, 2022 19:37
@moljac
Copy link
Contributor

moljac commented Nov 16, 2022

I think SignList.xml should be added too.

@moljac
Copy link
Contributor

moljac commented Nov 16, 2022

Q: How/when do you decide to do "template sets"?

just curious.

@jpobst
Copy link
Contributor Author

jpobst commented Nov 17, 2022

Is there any reason not to add Xamarin.* to the SignList.xml like XC does?
https://github.com/xamarin/XamarinComponents/blob/main/SignList.xml#L4-L7

I think it's pretty safe to say that we want everything that starts with Xamarin to be signed.

@jpobst
Copy link
Contributor Author

jpobst commented Nov 17, 2022

Q: How/when do you decide to do "template sets"?

Ideally, I think we want as few templates as possible. The majority of the content in them is duplicated and it means we have to update many places when we want to make changes (ie: dotnet/android-libraries#629).

Eventually I plan on working to reduce the number of templates we have by making the default template more flexible, but it's not a priority.

For BillingClient it was similar enough to the rest of GPS to use the template. Also the XC version did not use XBD which is required since BillingClient is Android SDK licensed, so that had to change anyways.

@jpobst jpobst force-pushed the import-billing-client branch from f4aa3c5 to e3073df Compare November 17, 2022 15:16
@jpobst jpobst merged commit 87c12d9 into main Nov 17, 2022
@jpobst jpobst deleted the import-billing-client branch November 17, 2022 19:10
@vecalion
Copy link

@jpobst @moljac I created a PR updating the billingclient to 5.0.0.
xamarin/XamarinComponents#1416
Should I get it here or will you take care of updating the lib?

@moljac
Copy link
Contributor

moljac commented Dec 2, 2022

@vecalion Thanks a lot. I will check it, but Biling client is now in GPS-FB-MLKit repo and we'll take care of updates.

@jpobst @moljac I created a PR updating the billingclient to 5.0.0. xamarin/XamarinComponents#1416 Should I get it here or will you take care of updating the lib?

No. It is OK. I will take care. Just to solve few issues I have. Updates will now be automagic in sync with GPS-FB-MLKit packages - twice per month.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants