Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Tizen] Fix dependency service registration correctly #10287

Merged
merged 1 commit into from
Apr 13, 2020
Merged

[Tizen] Fix dependency service registration correctly #10287

merged 1 commit into from
Apr 13, 2020

Conversation

rookiejava
Copy link
Collaborator

@rookiejava rookiejava commented Apr 10, 2020 •
edited
Loading

Description of Change

This PR fix MediaPlayerImpl dependency service registration correctly.

Issues Resolved

None

API Changes

Below methods are added into Xamarin.Forms.PlatformConfiguration.TizenSpecific.IMediaPlayer interface.

  • Task Start();
  • void Stop();
  • void Pause();

Platforms Affected

  • Tizen

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@rookiejava rookiejava requested review from samhouts and rmarinho April 10, 2020 04:51
@rookiejava rookiejava force-pushed the fix-tizen-dep-service branch from d0ae1b6 to a1fce0f Compare April 13, 2020 04:14
@rookiejava rookiejava mentioned this pull request Apr 13, 2020
Merged
@samhouts samhouts added the Core label Apr 13, 2020
@rmarinho rmarinho merged commit ed05053 into xamarin:4.6.0 Apr 13, 2020
@samhouts samhouts added this to the 4.6.0 milestone Apr 16, 2020
@rookiejava rookiejava mentioned this pull request Jul 1, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@samhouts samhouts Awaiting requested review from samhouts

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner

Assignees
No one assigned
Labels
Core p/Tizen
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rookiejava @rmarinho @samhouts