Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Handlers] Map CornerRadius property in ButtonHandlers #13865

Closed
wants to merge 3 commits into from

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Feb 25, 2021

Description of Change

Map CornerRadius property in ButtonHandlers.

Platforms Affected

  • iOS
  • Android

PR Checklist

  • Targets the correct branch
  • Include handlers tests
  • Tests are passing (or failures are unrelated)

@hartez
Copy link
Contributor

hartez commented Feb 25, 2021

I think we should hold off on this one until we have a better handle on what we're doing with shapes. If we can do a generic clip shape at the MAUI level, then we won't need to add a specific CornerRadius property; we can keep that at the Controls level and implement it using the clip shape.

@GalaxiaGuy
Copy link
Contributor

If this does ahead (I don't know what the plan is with shapes), should it be based on this:

dotnet/maui#10

@hartez
Copy link
Contributor

hartez commented Mar 4, 2021

Going to close this for now; we're close to having the underlying parts in MAUI that we can look at doing clipping shapes again for universal rounded/beveled/whatever edges on things.

If we decide not to go that direction, we can re-open and port this PR.

@hartez hartez closed this Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants