Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Invalidate measure of Label when FormattedText changes #303

Merged
merged 1 commit into from
Aug 16, 2016

Conversation

akihikodaki
Copy link
Contributor

@akihikodaki akihikodaki commented Aug 14, 2016

Description of Change

Changes in FormattedText such as FormattedText.Spans.Add can change the length of text and the measure of Label. This commit assures that Label properly apply the change.

Bugs Fixed

  • Sorry but I have not opened an issue.

API Changes

Nothing.

Behavioral Changes

Nothing.

PR Checklist

  • [*] Has tests (if omitted, state reason in description)
  • [*] Rebased on top of master at time of PR
  • [*] Changes adhere to coding standard
  • [*] Consolidate commits as makes sense

@dnfclas
Copy link

dnfclas commented Aug 14, 2016

Hi @akihikodaki, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
Copy link

dnfclas commented Aug 14, 2016

@akihikodaki, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@ahmedalejo
Copy link

That´s cool, this certainly may fix issues i am having (sometimes) with my
"bindable" Spans

On Sun, 14 Aug 2016 at 00:09 .Net Foundation Contribution License
Agreements notifications@github.com wrote:

@akihikodaki https://github.com/akihikodaki, Thanks for signing the
contribution license agreement so quickly! Actual humans will now validate
the agreement and then evaluate the PR.

Thanks, DNFBOT;


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#303 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGr-6gYsJLtwwm4N2PiGGFF8LTCyrlQLks5qfob_gaJpZM4Jjz7T
.

@jassmith jassmith merged commit 966683a into xamarin:master Aug 16, 2016
@samhouts samhouts added this to the 2.3.3 milestone Jun 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants