UtcToLocalDateTimeConverter?

[LeoJHarris]

Do we have a UtcToLocalDateTimeConverter in the library if not is this something we can consider adding?

[AndreiMisiukevich]

Hi @LeoJHarris
Currently we have only such one https://github.com/xamarin/XamarinCommunityToolkit/blob/main/src/CommunityToolkit/Xamarin.CommunityToolkit/Converters/DateTimeOffsetConverter.shared.cs

I guess we can add UtcToLocalDateTimeConverter (small note: string format parameter should be used for displaying value if passed)

[LeoJHarris]

@AndreiMisiukevich I thought something like this might suffice:

public class UtcToLocalDateTimeConverter : IValueConverter
    {
        public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
        {
            if (parameter is string dateTimeFormat)
            {
                if (value is DateTimeOffset dateTimeOffset)
                {
                    return dateTimeOffset.UtcDateTime.ToLocalTime().ToString(dateTimeFormat);
                }
                if (value is DateTime dateTime)
                {
                    return dateTime.ToLocalTime().ToString(dateTimeFormat);
                }
            }
            return string.Empty;
        }

        public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
        {
            throw new NotImplementedException();
        }
    }

Would accept DateTimeOffset and DateTime types.

[AndreiMisiukevich]

@LeoJHarris
Then this converter should have name "UtcDateTimeToLocalStringConverter" or something similar
Also, we should return a proper value if dateFormat is not provided as well.

[LeoJHarris]

@AndreiMisiukevich have implemented the converter will PR shortly for review

[LeoJHarris]

@AndreiMisiukevich @jfversluis first time PR, can you kindly advise the target branch to PR for a new Converter. Thanks

[LeoJHarris]

As a side note I couldn't get the unit tests to run for TestCaseSource, kept getting following:

unit test system.collections.generic.list could not be loaded

Not sure if environment issue on my end.

Also with regards to datetime format we can either default to a format if not provided or throw exception to user. I think a default would be better.

[jfversluis]

Merged