[Bug] DrawingCompletedCommand improperly implemented

[dansiegel]

Description

The Renderers seems to have improperly implemented calling the Command. As a matter of standard practice, CanExecute for a Command expects the same value that will be passed to Execute. The purpose of CanExecute is to evaluate the Command Parameter to determine whether or not it should execute. The sample below points to the UWP renderer, but it appears all of the platforms have implemented this the same wrong way.

XamarinCommunityToolkit/src/CommunityToolkit/Xamarin.CommunityToolkit/Views/DrawingView/Renderer/DrawingViewRenderer.uwp.cs

Lines 82 to 83 in 17a23ee

	if (Element.DrawingCompletedCommand?.CanExecute(null) ?? false)
	Element.DrawingCompletedCommand.Execute(elementPoints);

Steps to Reproduce

n/a

Expected Behavior

A Command's CanExecute(object obj) should have the same object passed in that is passed into the Execute(object obj).

Actual Behavior

A null value is passed to CanExecute, the points are passed to Execute.

Basic Information

• Version with issue: 1.2

Workaround

n/a

Reproduction imagery

n/a

Reproduction Link

n/a

[jfversluis]

Good catch, thanks!

[bijington]

I am in and working around the DrawingView so happy to pick this up

[VladislavAntonyuk]

Fix in #1475

[pictos]

Closing this issue, since the related PR is already merged.