Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

Conversation

RonnyRos
Copy link
Contributor

@RonnyRos RonnyRos commented Apr 22, 2021

Description of Change

My first PR.

Should fix the tabindicator resetting to default width, now it remembers the set tabindicator width set.
Should fix the tabindicator not following the selected tab, now follows the selected tab.

Tested on a Android emulator, should probably be tested more.

Bugs Fixed

#947

Description of Change

Should fix the tabindicator resetting to default width, now it remembers to set tabindicator width while navigating.
Should fix the tabindicator not following the selected tab. It now should follow the tab.

Tested only on a Android emulator, should probably be tested more.
Sample is in TabWidth view where indicatorwidth is set.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard

@ghost
Copy link

ghost commented Apr 22, 2021

CLA assistant check
All CLA requirements met.

@AndreiMisiukevich
Copy link
Contributor

Hey @RonnyRos something went wrong.
Did you want to submit a PR to develop branch instead?

@RonnyRos RonnyRos changed the base branch from main to develop April 23, 2021 07:56
@RonnyRos
Copy link
Contributor Author

Yes i did, changed it now. Thank you.

@jfversluis jfversluis added a/TabView bug Something isn't working. Breaky break. labels Apr 29, 2021
@xamarin xamarin deleted a comment from net-foundation-cla bot Jun 18, 2021
@TheCodeTraveler TheCodeTraveler changed the base branch from develop to main November 11, 2021 01:36
@TheCodeTraveler
Copy link
Contributor

@RonnyRos Can you please enable Allow Edits From Maintainers? https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

This PR is currently out-of-date with the main branch and we need to be able to click the "Update Branch" button to be unblocked from merging it.

Copy link
Contributor

@TheCodeTraveler TheCodeTraveler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RonnyRos!

@TheCodeTraveler TheCodeTraveler merged commit 2b1c7a1 into xamarin:main Nov 11, 2021
@RonnyRos RonnyRos deleted the bugfix/tabindicatorwidth branch November 11, 2021 20:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/TabView bug Something isn't working. Breaky break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants