Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

Conversation

bondarenkod
Copy link
Contributor

@bondarenkod bondarenkod commented Dec 14, 2021

Description of Bug

The issue is fully described #1761

Issues Fixed

Behavioral Changes

PR Checklist

  • Has a linked Issue, and the Issue has been approved
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard

The fix was tested on the iOS emu+device and Android device, working as expected.

@bondarenkod bondarenkod changed the title pr to fix issue #1761 (draft) Fix for [iOS] Unable to chain display Popup calls or to display two popup simultaneously #1761 (draft) Dec 14, 2021
@pictos
Copy link
Contributor

pictos commented Dec 14, 2021

cc: @ahoefling

@pictos pictos added a/popup bug Something isn't working. Breaky break. labels Dec 14, 2021
@SkyeHoefling
Copy link
Contributor

SkyeHoefling commented Dec 15, 2021

Thanks for the contribution, I took a glance from my mobile and the code change makes sense. Since it is a change in the shared code we need to validate this doesn't break Android or UWP

Has this been verified on all platforms?

@bondarenkod
Copy link
Contributor Author

@ahoefling Hi!
Here are tests for all three platforms:
iOS (have no idea what's wrong with the BG, some glitch, just moved to VS22 today):

20211215_190711000_iOS.mp4

Android:

Screen_Recording_20211215-171759.mp4

UWP:

15_12_2021__17_17_10__db2bcf05-a728-43eb-a68d-eca523e9e6f0.mp4

Copy link
Contributor

@SkyeHoefling SkyeHoefling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing videos of everything it made it easier to review. The code change looks good to me and since we have tests for all platforms I think we can merge this 🚀🚀🚀

@bondarenkod bondarenkod changed the title Fix for [iOS] Unable to chain display Popup calls or to display two popup simultaneously #1761 (draft) Fix for [iOS] Unable to chain display Popup calls or to display two popup simultaneously #1761 Dec 16, 2021
@pictos
Copy link
Contributor

pictos commented Dec 16, 2021

I'll do the final review until tomorrow and everything looks good I'll merge it. Thanks, @ahoefling, and @bondarenkod you both rock❣

@pictos pictos merged commit 7466780 into xamarin:main Dec 22, 2021
@bondarenkod bondarenkod deleted the gh-issue-1761 branch January 7, 2022 09:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/popup bug Something isn't working. Breaky break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [iOS] Unable to chain display Popup calls or to display two popup simultaneously
4 participants