This repository was archived by the owner on May 1, 2024. It is now read-only.
[Bug] GravatarImageSource throws exception when offline #1816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>netcoreapp2.1;netcoreapp3.1;net461</TargetFrameworks> |
There was a problem hiding this comment.
fix build out of the box. netcoreapp2.1 is the end of support
| } | ||
|
|
||
| static void UpdateStatusBarAppearance(UIWindow window) | ||
| static void UpdateStatusBarAppearance(UIWindow? window) |
There was a problem hiding this comment.
see line 97. window can be null
VladislavAntonyuk
requested review from
TheCodeTraveler,
pictos and
bijington
bijington
reviewed
Feb 21, 2022
| return Array.Empty<byte>(); | ||
|
|
||
| return await response.Content.ReadAsByteArrayAsync(); | ||
| return await response.Content.ReadAsByteArrayAsync(); |
There was a problem hiding this comment.
looks like no.
pictos
reviewed
Feb 21, 2022
...ews/GravatarImageSource/Shared/GravatarImageSourceHandler.android.ios.macos.tizen.uwp.wpf.cs
Outdated
Show resolved
Hide resolved
pictos
approved these changes
Feb 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GravatarImageSource throws exception when offline
Fix Nullable
Description of Bug
Issues Fixed
Behavioral Changes
PR Checklist
approved