Fix for Bug #934 (IconTintColorEffect does not work when the image is…

[mike-rowley]

This is the PR for Bug #934 IconTintColorEffect does not work when the image is in Shared project as EmbeddeResource
#934

I have implemented the fix @TheDude1604 suggested in the bug report and it resolves the issue on IOS. I have tested it on a physical device as well as a simulator.

If there are any issues please let me know and I will try to resolve them. Thanks for considering this PR.

[net-foundation-cla]

All CLA requirements met.

[ghost]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ mike-rowley sign now
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[pictos]

@mike-rowley can you assign the CLA?

[mike-rowley]

I did both CLAs, now when I click the "sign now" link it says "You have signed the CLA for multiple repositories or organizations" and all options are disabled with my name etc in the fields. Seems like some sort of glitch in the CLA process unless there is something I am missing.

[pictos]

@brminnick do you have the permission to check if everything it's fine?

[TheCodeTraveler]

Done ✅

[pictos]

@mike-rowley thanks for sharing the solution with us❣️
So, this retry logic doesn't look very solid to me, because there's a chance to the image loads after all retries attempts, would be good if we can use something more solid. So my suggestion is to use the IsLoading property inside the XF.Image control, here's a snippet of code that I tried on my end and worked. I put this code inside the void SetUIImageViewTintColor(UIImageView imageView, Color color) method.

if (imageView.Image == null)
{
    Element.PropertyChanged += (_, e) =>
    {
        if (e.PropertyName == Image.IsLoadingProperty.PropertyName)
        {
            var b = Element as Xamarin.Forms.Image ?? throw new NullReferenceException();
            if (!b.IsLoading)
            {
                SetUIImageViewTintColor(imageView, color);
            }
        }
    };
}

I'm not sure if we have something like that for the ImageButton control, can you take a look on that? If you need any help, just let me know (:

[mike-rowley]

Thanks @pictos I took your code and tested it on my side and it works great, a much more elegant solution! I also converted that code to the Button and it works there as well so I pushed another PR with the updated code.

[pictos]

@mike-rowley glad that you liked the solution! I have just a feel comments and after that we should be good to merge it

[mike-rowley]

@pictos Good call on unsubscribing, I think this version should do it.

Somehow I accidentally referenced a bug from 2017 in the summary when I pushed it and I am not sure how to change that "#2" in the summary.

[pictos]

@mike-rowley thanks for this!