Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

SignalR.Java.Client-5.0.6 #1196

Merged
merged 7 commits into from
Jun 21, 2021
Merged

SignalR.Java.Client-5.0.6 #1196

merged 7 commits into from
Jun 21, 2021

Conversation

4brunu
Copy link
Contributor

@4brunu 4brunu commented Jun 7, 2021

No description provided.

@4brunu 4brunu changed the title Create bind go SignalR Java Client 5.0.6 Create bind for SignalR Java Client 5.0.6 Jun 7, 2021
@moljac
Copy link
Member

moljac commented Jun 7, 2021

In order to mitigate issues like:

#1176

please add Xamarin prefix to:

  • nuget packageid
  • assemblyname
  • namespaces (including Metadata)

@4brunu
Copy link
Contributor Author

4brunu commented Jun 10, 2021

@moljac I think it's done with cd99608

@moljac moljac changed the title Create bind for SignalR Java Client 5.0.6 SignalR.Java.Client-5.0.6 Jun 20, 2021
moljac
moljac approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@moljac moljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
minor naming changes (ASP.NET to AspNet for consistency with other Microsoft packages) and manifest.yml

@moljac moljac merged commit 792d690 into xamarin:main Jun 21, 2021
@4brunu 4brunu deleted the feature/signalr-java-client branch June 21, 2021 12:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moljac moljac moljac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4brunu @moljac