Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AudioSwitch-1.1.2 #1197

Merged
merged 6 commits into from
Jun 21, 2021
Merged

AudioSwitch-1.1.2 #1197

merged 6 commits into from
Jun 21, 2021

Conversation

4brunu
Copy link
Contributor

@4brunu 4brunu commented Jun 7, 2021

No description provided.

@moljac
Copy link
Member

moljac commented Jun 7, 2021

In order to mitigate issues like:

#1176

please add Xamarin prefix to:

  • nuget packageid
  • assemblyname
  • namespaces (including Metadata)

@4brunu
Copy link
Contributor Author

4brunu commented Jun 7, 2021

@moljac I think a5de8ce did what you asked, could you please confirm?
Thanks

@moljac moljac changed the title Create bind for AudioSwitch 1.1.2 AudioSwitch-1.1.2 Jun 20, 2021
moljac
moljac approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@moljac moljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
minor chnges (manifest.yml)

@moljac moljac merged commit f9f092e into xamarin:main Jun 21, 2021
@4brunu 4brunu deleted the feature/audioswitch branch June 21, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moljac moljac moljac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4brunu @moljac