Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioSwitch-1.1.4 #1316

Merged
merged 14 commits into from
Mar 10, 2022
Merged

AudioSwitch-1.1.4 #1316

merged 14 commits into from
Mar 10, 2022

Conversation

4brunu
Copy link
Contributor

@4brunu 4brunu commented Jan 5, 2022

AudioSwitch 1.1.3 added support to Android 12, because of the bluetooth changes, but also introduced some bugs.
AudioSwitch 1.1.4 fixes those bugs.

Copy link
Member

@moljac moljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moljac
Copy link
Member

moljac commented Feb 7, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@moljac
Copy link
Member

moljac commented Feb 21, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@moljac
Copy link
Member

moljac commented Mar 3, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@4brunu
Copy link
Contributor Author

4brunu commented Mar 3, 2022

@moljac it's weird that this fails to build em macOS, I have tested this locally and it builds successfully.
Could you please check what is the error in the build output please? Because I don't have access to it.

@moljac
Copy link
Member

moljac commented Mar 3, 2022

@moljac it's weird that this fails to build em macOS, I have tested this locally and it builds successfully. Could you please check what is the error in the build output please? Because I don't have access to it.

Here:

     2>/Library/Frameworks/Mono.framework/External/xbuild/Xamarin/Android/Xamarin.Android.Legacy.targets(267,5): error XA0000: Could not determine API level for $(TargetFrameworkVersion) of 'v12.0'. [/Users/runner/work/1/s/Android/AudioSwitch/source/AudioSwitch/AudioSwitch.csproj]
     2>Done Building Project "/Users/runner/work/1/s/Android/AudioSwitch/source/AudioSwitch/AudioSwitch.csproj" (Build target(s)) -- FAILED.
     2>Done Building Project "/Users/runner/work/1/s/Android/AudioSwitch/source/AudioSwitch/AudioSwitch.csproj" (Pack target(s)) -- FAILED.
     1>Done Building Project "/Users/runner/work/1/s/Android/AudioSwitch/source/AudioSwitch.sln" (Pack target(s)) -- FAILED.

@4brunu
Copy link
Contributor Author

4brunu commented Mar 3, 2022

Thanks, CI is now passing 👍

@moljac moljac merged commit fbc3cb4 into xamarin:main Mar 10, 2022
@4brunu 4brunu deleted the feature/audioswitch-1.1.4 branch May 11, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants