This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
Do not quote arguments with backslash separator #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This particular behavior breaks invoking 7zip with provisionator, because the output path parameter is specified as `-o[PATH]`. If the `PATH` has no spaces, no quoting is necessary around `-o` and it just works. However, with the current behavior, specifying `"-o[PATH]"` fails with 7zip not able to find the path. Since we're not quoting `/` either, I wonder what's the rationale for quoting when `\` is present? Granted, that format for 7zip CLI is weird (all parameter values to right after the switch, with no space), and if quoting is needed, the quote is supposed to go around the switch value, but exclude the switch itself, but at least one could work around that by ensuring there are no whitespaces in the `-o` parameter, if it weren't for this existing quoting behavior.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This particular behavior breaks invoking 7zip with provisionator, because the output path
parameter is specified as
-o[PATH]. If thePATHhas no spaces, no quoting is necessaryaround
-oand it just works. However, with the current behavior, specifying"-o[PATH]"fails with 7zip not able to find the path.
Since we're not quoting
/either, I wonder what's the rationale for quoting when\ispresent? Granted, that format for 7zip CLI is weird (all parameter values to right after the
switch, with no space), and if quoting is needed, the quote is supposed to go around the
switch value, but exclude the switch itself, but at least one could work around that by
ensuring there are no whitespaces in the
-oparameter, if it weren't for this existing quotingbehavior.