This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
Build: .NET 6 SDK, drop ilrepack from build, change some target frameworks #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…works .NET Core 2.1 is not supported on arm64 Macs. .NET 6.0.300 SDK is a long-term support release with broad compatibility. Newer `Microsoft.Build` package versions no longer have `netstandard2.0` support (see dotnet/msbuild#4521). Update `Xamarin.MSBuild.Sdk` to multi-target `net6.0` and `net472` to address this. `Xamarin.BuildConsolidator` depends on ILRepack, which is not supported in .NET 6. The only actively-used consolidation support comes from `PrepareConsolidationProject` in `Xamarin.MSBuild.Sdk`, so remove the unused projects from the build.
|
Converting to draft until unit tests are fixed. |
|
FYI I fixed ILRepack and it's glorious now :) |
@KirillOsenkov that is awesome! Sadly mirepoix isn't really being used anywhere anymore, but there are TONS of projects using ilrepack so glad to hear it's working again. 😃 |
|
Yeah I realize I'm a bit late with this, but hey! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET Core 2.1 is not supported on arm64 Macs. .NET 6.0.300 SDK is a
long-term support release with broad compatibility.
Newer
Microsoft.Buildpackage versions no longer havenetstandard2.0support (see dotnet/msbuild#4521). Update
Xamarin.MSBuild.Sdkto multi-targetnet6.0andnet472to addressthis.
Xamarin.BuildConsolidatordepends on ILRepack, which is not supportedin .NET 6. The only actively-used consolidation support comes from
PrepareConsolidationProjectinXamarin.MSBuild.Sdk, so remove theunused projects from the build.