-
Notifications
You must be signed in to change notification settings - Fork 514
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[AppKit] Make the files containing enums API source files instead of …
…Core source files. (#12191) This makes it easier to include/exclude certain enums in Mac Catalyst (since we can use [NoMacCatalyst] instead of littering the files with "#if MACCATALYST"). It required moving a little bit of unrelated code out of the enums source files, but this is a much smaller change than moving all of the enums out of these files (see #12185 for how that ends up).
- Loading branch information
1 parent
a010778
commit 28bb8bc
Showing
3 changed files
with
13 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28bb8bc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ [CI Build] Tests failed on Build ❌
Tests failed on Build.
API diff
✅ API Diff from stable
View API diff
API & Generator diff
✅ API Diff (from PR only) (no change)
ℹ️ Generator Diff (please review changes)
Packages generated
View packages
Test results
38 tests failed, 186 tests passed.
Failed tests
Pipeline on Agent XAMBOT-1035.BigSur'
[AppKit] Make the files containing enums API source files instead of Core source files. (#12191)
28bb8bc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Tests failed catastrophically on VSTS: device tests tvOS 🔥
Not enough free space in the host.
Pipeline on Agent
[AppKit] Make the files containing enums API source files instead of Core source files. (#12191)
28bb8bc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.
Pipeline on Agent
[AppKit] Make the files containing enums API source files instead of Core source files. (#12191)
28bb8bc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Tests passed on macOS Mac Catalina (10.15) ✅
Tests passed
All tests on macOS X Mac Catalina (10.15) passed.
Pipeline on Agent
[AppKit] Make the files containing enums API source files instead of Core source files. (#12191)
28bb8bc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.
Pipeline on Agent
[AppKit] Make the files containing enums API source files instead of Core source files. (#12191)
28bb8bc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Tests passed on macOS Mac Mojave (10.14) ✅
Tests passed
All tests on macOS X Mac Mojave (10.14) passed.
Pipeline on Agent
[AppKit] Make the files containing enums API source files instead of Core source files. (#12191)
28bb8bc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Tests passed on macOS Mac High Sierra (10.13) ✅
Tests passed
All tests on macOS X Mac High Sierra (10.13) passed.
Pipeline on Agent
[AppKit] Make the files containing enums API source files instead of Core source files. (#12191)