Skip to content

Commit

Permalink
[msbuild] Set UseSecureTimestamp inside _CodesignFrameworks too (#…
Browse files Browse the repository at this point in the history 
…12387)

That's needed for Xamarin.Mac and was _lost_ when the task was merged
between XI and XM.

Fixes #11784
  • Loading branch information
@spouliot
spouliot committed Aug 10, 2021
1 parent 687b3b9 commit 300fc28
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions msbuild/Xamarin.Shared/Xamarin.Shared.targets
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1170,6 +1170,7 @@ Copyright (C) 2018 Microsoft. All rights reserved.
Resources="@(_Frameworks)"
SigningKey="$(_FrameworkCodeSigningKey)"
ExtraArgs="$(CodesignExtraArgs)"
UseSecureTimestamp="$(UseHardenedRuntime)"
>
</Codesign>

Expand Down

4 comments on commit 300fc28

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

✅ API Diff (from PR only) (no change)
✅ Generator Diff (only version changes)

Packages generated

View packages

Test results

1 tests failed, 228 tests passed.

Failed tests

  • Documentation/All: Failed

Pipeline on Agent XAMBOT-1030.BigSur'
[msbuild] Set UseSecureTimestamp inside _CodesignFrameworks too (#12387)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests iOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[msbuild] Set UseSecureTimestamp inside _CodesignFrameworks too (#12387)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests tvOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[msbuild] Set UseSecureTimestamp inside _CodesignFrameworks too (#12387)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Tests failed on macOS M1 - Mac Big Sur (11.5) ❌

Tests failed on M1 - Mac Big Sur (11.5).

Failed tests are:

  • xammac_tests

Pipeline on Agent
[msbuild] Set UseSecureTimestamp inside _CodesignFrameworks too (#12387)

Please sign in to comment.