Skip to content

Commit

Permalink
[OpenGL] Add Support for DotNet Attributes (#12494)
Browse files Browse the repository at this point in the history
  • Loading branch information
@tj-devel709
tj-devel709 committed Aug 24, 2021
1 parent 207285a commit 3847fe0
Show file tree
Hide file tree
Showing 3 changed files with 35 additions and 4 deletions.
10 changes: 9 additions & 1 deletion src/OpenGL/CGLContext.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,17 @@

using ObjCRuntime;
using Foundation;
using System.Runtime.Versioning;

namespace OpenGL {
[Deprecated (PlatformName.MacOSX, 10, 14, message : "Use 'Metal' Framework instead.")]
#if !NET
[Deprecated (PlatformName.MacOSX, 10, 14, message: "Use 'Metal' Framework instead.")]
#else
[UnsupportedOSPlatform ("macos10.14")]
#if MONOMAC
[Obsolete ("Starting with macos10.14 Use 'Metal' Framework instead.", DiagnosticId = "BI1234", UrlFormat = "https://github.com/xamarin/xamarin-macios/wiki/Obsolete")]
#endif
#endif
public class CGLContext : INativeObject, IDisposable {
IntPtr handle;

Expand Down
19 changes: 17 additions & 2 deletions src/OpenGL/CGLEnums.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,18 @@
//
using System;
using ObjCRuntime;
using System.Runtime.Versioning;

namespace OpenGL {

[Deprecated (PlatformName.MacOSX, 10, 14, message : "Use 'Metal' Framework instead.")]
#if !NET
[Deprecated (PlatformName.MacOSX, 10, 14, message: "Use 'Metal' Framework instead.")]
#else
[UnsupportedOSPlatform ("macos10.14")]
#if MONOMAC
[Obsolete ("Starting with macos10.14 Use 'Metal' Framework instead.", DiagnosticId = "BI1234", UrlFormat = "https://github.com/xamarin/xamarin-macios/wiki/Obsolete")]
#endif
#endif
public enum CGLErrorCode : uint
{
NoError = 0, /* no error */
Expand All @@ -50,7 +58,14 @@ public enum CGLErrorCode : uint

}

[Deprecated (PlatformName.MacOSX, 10, 14, message : "Use 'Metal' Framework instead.")]
#if !NET
[Deprecated (PlatformName.MacOSX, 10, 14, message: "Use 'Metal' Framework instead.")]
#else
[UnsupportedOSPlatform ("macos10.14")]
#if MONOMAC
[Obsolete ("Starting with macos10.14 Use 'Metal' Framework instead.", DiagnosticId = "BI1234", UrlFormat = "https://github.com/xamarin/xamarin-macios/wiki/Obsolete")]
#endif
#endif
public enum CGLPixelFormatAttribute : uint
{
AllRenderers = 1,
Expand Down
10 changes: 9 additions & 1 deletion src/OpenGL/CGLPixelFormat.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,17 @@
using System.Collections.Generic;
using ObjCRuntime;
using Foundation;
using System.Runtime.Versioning;

namespace OpenGL {
[Deprecated (PlatformName.MacOSX, 10, 14, message : "Use 'Metal' Framework instead.")]
#if !NET
[Deprecated (PlatformName.MacOSX, 10, 14, message: "Use 'Metal' Framework instead.")]
#else
[UnsupportedOSPlatform ("macos10.14")]
#if MONOMAC
[Obsolete ("Starting with macos10.14 Use 'Metal' Framework instead.", DiagnosticId = "BI1234", UrlFormat = "https://github.com/xamarin/xamarin-macios/wiki/Obsolete")]
#endif
#endif
public class CGLPixelFormat : INativeObject, IDisposable {
internal IntPtr handle;

Expand Down

5 comments on commit 3847fe0

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

✅ API Diff (from PR only) (no change)
✅ Generator Diff (only version changes)

Packages generated

View packages

Test results

2 tests failed, 247 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2638 Passed: 2489 Inconclusive: 35 Failed: 1 Ignored: 148)
  • Documentation/All: Failed

Pipeline on Agent XAMBOT-1025.BigSur'
[OpenGL] Add Support for DotNet Attributes (#12494)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests iOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[OpenGL] Add Support for DotNet Attributes (#12494)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests tvOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[OpenGL] Add Support for DotNet Attributes (#12494)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Tests failed on macOS M1 - Mac Big Sur (11.5) ❌

Tests failed on M1 - Mac Big Sur (11.5).

Failed tests are:

  • xammac_tests

Pipeline on Agent
[OpenGL] Add Support for DotNet Attributes (#12494)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests passed on macOS Mac Mojave (10.14) ✅

Tests passed

All tests on macOS X Mac Mojave (10.14) passed.

Pipeline on Agent
[OpenGL] Add Support for DotNet Attributes (#12494)

Please sign in to comment.