Skip to content

Commit

Permalink
[WebKit] Add support for Xcode 14 beta 5. (#15700)
Browse files Browse the repository at this point in the history
* [WebKit] Add support for Xcode 14 beta 5.

* Clean changes.

* Update src/wkwebkit.cs

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
  • Loading branch information
mandel-macaque and rolfbjarne authored Aug 24, 2022
1 parent 3df41db commit 6386550
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 6 deletions.
14 changes: 14 additions & 0 deletions src/wkwebkit.cs
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,15 @@ public enum WKFullscreenState : long {
ExitingFullscreen,
}

[iOS (16,0), MacCatalyst (16,0), Mac (13,0)]
[Native]
public enum WKDialogResult : long
{
ShowDefault = 1,
AskAgain,
Handled,
}

[iOS (8,0), Mac (10,10)] // Not defined in 32-bit
[BaseType (typeof (NSObject))]
[DisableDefaultCtor ()] // Crashes during deallocation in Xcode 6 beta 2. radar 17377712.
Expand Down Expand Up @@ -626,6 +635,11 @@ void RunJavaScriptTextInputPanel (WKWebView webView, string prompt, [NullAllowed
[Mac (12,0), iOS (15,0), MacCatalyst (15,0), NoTV]
[Export ("webView:requestMediaCapturePermissionForOrigin:initiatedByFrame:type:decisionHandler:")]
void RequestMediaCapturePermission (WKWebView webView, WKSecurityOrigin origin, WKFrameInfo frame, WKMediaCaptureType type, Action<WKPermissionDecision> decisionHandler);

[Async]
[NoMac, iOS (16,0), MacCatalyst (16,0)] // headers say 13, is not true since the enum is from 16
[Export ("webView:showLockdownModeFirstUseMessage:completionHandler:")]
void ShowLockDownMode (WKWebView webView, string firstUseMessage, Action<WKDialogResult> completionHandler);
}

[iOS (8,0), Mac (10,10)] // Not defined in 32-bit
Expand Down
2 changes: 0 additions & 2 deletions tests/xtro-sharpie/api-annotations-dotnet/iOS-WebKit.todo

This file was deleted.

This file was deleted.

2 changes: 0 additions & 2 deletions tests/xtro-sharpie/iOS-WebKit.todo

This file was deleted.

1 change: 0 additions & 1 deletion tests/xtro-sharpie/macOS-WebKit.todo

This file was deleted.

5 comments on commit 6386550

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS: vsdrops gist (No breaking changes)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS: vsdrops gist (No breaking changes)
.NET (No breaking changes)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 638655093c25ef492a10603c1f0f894b7b438745 [CI build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💻 [CI Build] Tests on macOS Mac Catalina (10.15) passed 💻

All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 638655093c25ef492a10603c1f0f894b7b438745 [CI build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • xammac_tests
  • monotouch-test

Pipeline on Agent
Hash: 638655093c25ef492a10603c1f0f894b7b438745 [CI build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📚 [CI Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMMINI-061.Monterey'
Hash: 638655093c25ef492a10603c1f0f894b7b438745 [CI build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 3 tests failed, 225 tests passed.

Failures

❌ bcl tests

1 tests failed, 68 tests passed.
  • [xUnit] Mono SystemCoreXunit Part 2/tvOS - simulator/Debug: TimedOut

Html Report (VSDrops) Download

❌ introspection tests

2 tests failed, 11 tests passed.
  • introspection/watchOS 32-bits - simulator/Debug: TimedOut
  • introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [CI build]

Please sign in to comment.