Skip to content

Commit

Permalink
[CI] Move the sing and notarize steps to a VM. (#14854)
Browse files Browse the repository at this point in the history
We do not have any special requirements to perform the signing except
for the fact that needs to be EO complient. The new vm allows us to be
 EO complient and reduces the number of real bots that we use.
  • Loading branch information
mandel-macaque authored May 2, 2022
1 parent 1aa3e4d commit 7f77d1c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 34 deletions.
2 changes: 0 additions & 2 deletions tools/devops/automation/build-pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -346,8 +346,6 @@ stages:
keyringPass: $(pass--lab--mac--builder--keychain)
enableDotnet: ${{ parameters.enableDotnet }}
skipESRP: ${{ parameters.skipESRP }}
pool: ${{ parameters.pool }}


- ${{ if eq(parameters.enableAPIDiff, true) }}:
- stage: generate_api_diff
Expand Down
33 changes: 1 addition & 32 deletions tools/devops/automation/templates/build/prepare-pkg-stage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ parameters:
type: boolean
default: false # only to be used when testing the CI and we do not need a signed pkg

- name: pool
type: string
default: automatic

jobs:
- job: configure
displayName: 'Configure build'
Expand All @@ -28,40 +24,13 @@ jobs:
steps:
- template: ../common/configure.yml

- ${{ if eq(parameters.pool, 'automatic') }}:
- job: AgentPoolSelector # https://docs.microsoft.com/en-us/azure/devops/pipelines/process/phases?view=azure-devops&tabs=yaml
pool: # Consider using an agentless (server) job here, but would need to host selection logic as an Azure function: https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=azure-devops&tabs=schema#server
vmImage: ubuntu-latest
steps:
- checkout: none # https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=azure-devops&tabs=schema#checkout

# Selects appropriate agent pool based on trigger type (PR or CI); manually triggered builds target the PR pool
- template: azure-devops-pools/agent-pool-selector.yml@templates
parameters:
agentPoolPR: $(PRBuildPool)
agentPoolPRUrl: $(PRBuildPoolUrl)
agentPoolCI: $(CIBuildPool)
agentPoolCIUrl: $(CIBuildPoolUrl)

- job: sign_notarize
dependsOn:
- ${{ if eq(parameters.pool, 'automatic') }}:
- AgentPoolSelector
- configure
displayName: 'Sign & Notarize'
timeoutInMinutes: 1000
variables:
${{ if eq(parameters.pool, 'automatic') }}:
AgentPoolComputed: $[ dependencies.AgentPoolSelector.outputs['setAgentPool.AgentPoolComputed'] ]
${{ if eq(parameters.pool, 'ci') }}:
AgentPoolComputed: $(CIBuildPool)
${{ if eq(parameters.pool, 'pr') }}:
AgentPoolComputed: $(PRBuildPool)
pool:
name: $(AgentPoolComputed)
demands:
- Agent.OS -equals Darwin
- macios_image -equals v2.1 # Big Sur image with Xcode 12.4 and 12.5 installed
vmImage: internal-macos-11
workspace:
clean: all

Expand Down

5 comments on commit 7f77d1c

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 [CI Build] API Diff 📋

API Current PR diff

✅ API Diff (from PR only) (no change)

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

Generator diff

Generator Diff (no change)

Pipeline on Agent XAMMINI-055.Monterey'
Hash: 7f77d1c330e8e9b6ee5c7f84debd5ae0a58f7881

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • introspection

Pipeline on Agent
Hash: 7f77d1c330e8e9b6ee5c7f84debd5ae0a58f7881

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests on macOS Mac Catalina (10.15) failed ❌

Failed tests are:

  • introspection

Pipeline on Agent
Hash: 7f77d1c330e8e9b6ee5c7f84debd5ae0a58f7881

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📚 [CI Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMMINI-054.Monterey
Hash: 7f77d1c330e8e9b6ee5c7f84debd5ae0a58f7881

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌

Tests failed on VSTS: simulator tests iOS.

Test results

2 tests failed, 232 tests passed.

Failed tests

  • introspection/iOS Unified 64-bits - simulator/Debug (iOS 12.4) [dotnet]: Failed
  • introspection/tvOS - simulator/Debug (tvOS 12.4) [dotnet]: Failed

Pipeline on Agent XAMBOT-1017.Monterey
[CI] Move the sing and notarize steps to a VM. (#14854)

Please sign in to comment.