Skip to content

Commit

Permalink
[msbuild] Remove the MTouch and Mmp tasks. (#21608)
Browse files Browse the repository at this point in the history
They're legacy-only tasks.
  • Loading branch information
rolfbjarne authored Nov 20, 2024
1 parent 4675eea commit 9216a97
Show file tree
Hide file tree
Showing 9 changed files with 4 additions and 1,133 deletions.
2 changes: 1 addition & 1 deletion msbuild/Messaging/Xamarin.Messaging.Build/TaskRunner.cs
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ internal TaskRunner (ITaskSerializer serializer)

internal void LoadTasks (Assembly assembly) => tasks.AddRange (assembly.GetTypes ());

internal void LoadXamarinTasks () => LoadTasks (typeof (MacDev.Tasks.MTouch).Assembly);
internal void LoadXamarinTasks () => LoadTasks (typeof (MacDev.Tasks.XamarinTask).Assembly);

public ExecuteTaskResult Execute (string taskName, string inputs)
{
Expand Down
133 changes: 0 additions & 133 deletions msbuild/Xamarin.MacDev.Tasks/Tasks/BundlerTool.cs

This file was deleted.

2 changes: 0 additions & 2 deletions msbuild/Xamarin.MacDev.Tasks/Tasks/CreateInstallerPackage.cs
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,6 @@ void AppendExtraArgs (CommandLineArgumentBuilder args, string extraArgs)
string [] argv = CommandLineArgumentBuilder.Parse (extraArgs);
var customTags = new Dictionary<string, string> (StringComparer.OrdinalIgnoreCase) {
{ "projectdir", Path.GetDirectoryName (this.ProjectPath) },
// Apparently msbuild doesn't propagate the solution path, so we can't get it. - MTouchTaskBase.cs
// { "solutiondir", proj.ParentSolution is not null ? proj.ParentSolution.BaseDirectory : proj.BaseDirectory },
{ "appbundledir", this.AppBundleDir },
{ "targetpath", Path.Combine (Path.GetDirectoryName (target), Path.GetFileName (target)) },
{ "targetdir", Path.GetDirectoryName (target) },
Expand Down
Loading

6 comments on commit 9216a97

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

Please sign in to comment.