Skip to content

Commit

Permalink
[dotnet] We no longer need to add the entry assembly as a root assemb…
Browse files Browse the repository at this point in the history 
…ly for the linker.

Not only is it no longer necessary, it's wrong after dotnet/linker#3124.
  • Loading branch information
@rolfbjarne
rolfbjarne committed Dec 13, 2022
1 parent 4650336 commit 97d4e2e
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions dotnet/targets/Xamarin.Shared.Sdk.targets
View file
Original file line number Diff line number Diff line change
Expand Up @@ -574,9 +574,6 @@
<TrimMode>copy</TrimMode> <!-- Don't use 'copyused', because that might still end up saving some assemblies, and if that's the platform assembly, it may break the partial static registrar -->
</ResolvedFileToPublish>

<!-- Mark our entry assembly as a root assembly. -->
<TrimmerRootAssembly Include="@(ResolvedFileToPublish)" Condition="'%(ResolvedFileToPublish.Filename)' == '$(AssemblyName)' And '%(ResolvedFileToPublish.Extension)' == '.dll'" />

<!--
pre-mark custom steps
-->
Expand Down

3 comments on commit 97d4e2e

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 97d4e2e88c78ef74fdc629d8d8fce468fa02f43c [CI build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: 97d4e2e88c78ef74fdc629d8d8fce468fa02f43c [CI build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 12 tests failed, 211 tests passed.

Failures

❌ bcl tests

1 tests failed, 68 tests passed.
  • [xUnit] Mono SystemCoreXunit Part 1/tvOS - simulator/Debug: Crashed

Html Report (VSDrops) Download

❌ dotnettests tests

1 tests failed, 0 tests passed.
  • DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ monotouch tests

9 tests failed, 14 tests passed.
  • monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Test run crashed (exit code: 255).
    Test run crashed)
  • monotouch-test/iOS Unified 64-bits - simulator/Debug [dotnet]: Crashed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk) [dotnet]: Crashed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar) [dotnet]: Crashed
  • monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations) [dotnet]: Crashed
  • monotouch-test/tvOS - simulator/Debug [dotnet]: TimedOut
  • monotouch-test/tvOS - simulator/Debug (LinkSdk) [dotnet]: TimedOut
  • monotouch-test/tvOS - simulator/Debug (static registrar) [dotnet]: TimedOut
  • monotouch-test/tvOS - simulator/Release (all optimizations) [dotnet]: TimedOut

Html Report (VSDrops) Download

❌ xcframework tests

1 tests failed, 7 tests passed.
  • xcframework-test/tvOS - simulator/Debug [dotnet]: BuildFailure

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 97d4e2e88c78ef74fdc629d8d8fce468fa02f43c [CI build]

Please sign in to comment.