Skip to content

Commit

Permalink
[tests] Disable attribute duplication check (#13745)
Browse files Browse the repository at this point in the history 
- Disable check "[FAIL] Both '{t}' and '{m}' are marked with `{s}`." type and member on that type in NET
- Due to the behavior of NET6 style attributes, we are forced to duplicate availability attributes in many cases
- See #10170 for details
  • Loading branch information
@chamons
chamons committed Jan 18, 2022
1 parent c3e5d7e commit a9c2caa
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tests/introspection/ApiAvailabilityTest.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -553,8 +553,10 @@ void CheckDupes (MemberInfo m, Type t, ISet<string> type_level)
s = aa.ToString ();
#endif
if (s.Length > 0) {
#if !NET
if (type_level.Contains (s))
AddErrorLine ($"[FAIL] Both '{t}' and '{m}' are marked with `{s}`.");
#endif
if (member_level.Contains (s))
AddErrorLine ($"[FAIL] '{m}' is decorated more than once with `{s}`.");
else
Expand Down

4 comments on commit a9c2caa

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

API Current PR diff

ℹ️ API Diff (from PR only) (please review changes)

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

Generator diff

✅ Generator Diff (no change)

Packages generated

View packages

Test results

1 tests failed, 234 tests passed.

Failed tests

  • trimmode copy/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Test run crashed (exit code: 134).
    Tests run: 11 Passed: 6 Inconclusive: 0 Failed: 0 Ignored: 5)

Pipeline on Agent XAMMINI-068.BigSur'
[tests] Disable attribute duplication check (#13745)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests tvOS (no summary found). 🔥

Result file D:\a\1\s\Reports\TestSummary-tvos\TestSummary.md not found.

Pipeline on Agent
[tests] Disable attribute duplication check (#13745)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests iOS (no summary found). 🔥

Result file D:\a\1\s\Reports\TestSummary-iOS64\TestSummary.md not found.

Pipeline on Agent
[tests] Disable attribute duplication check (#13745)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Tests failed on macOS Mac Catalina (10.15) ❌

Tests failed on Mac Catalina (10.15).

Failed tests are:

  • introspection

Pipeline on Agent
[tests] Disable attribute duplication check (#13745)

Please sign in to comment.