Skip to content

Commit

Permalink
[AVFoundation] Make the notification change for xamcore 4 (#13134)
Browse files Browse the repository at this point in the history
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
  • Loading branch information
mandel-macaque and rolfbjarne committed Oct 27, 2021
1 parent 40db84a commit c2e2ac8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/avfoundation.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11996,7 +11996,7 @@ interface AVPlayerItem : NSCopying {
bool CanPlayFastForward { get; }

[Field ("AVPlayerItemTimeJumpedNotification")]
#if WATCH
#if !XAMCORE_4_0
[Notification]
#else
[Notification (typeof (AVPlayerItemTimeJumpedEventArgs))]
Expand Down
3 changes: 3 additions & 0 deletions tests/xtro-sharpie/common-AVFoundation.ignore
Original file line number Diff line number Diff line change
Expand Up @@ -82,3 +82,6 @@

# adding abstract member to an existing type would be a breaking change
!incorrect-protocol-member! AVQueuedSampleBufferRendering::hasSufficientMediaDataForReliablePlaybackStart is REQUIRED and should be abstract

# added for XAMCORE_4_0 since it is part of a new breaking change in a notification
!missing-field! AVPlayerItemTimeJumpedOriginatingParticipantKey not bound

6 comments on commit c2e2ac8

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

Packages generated

View packages

Test results

2 tests failed, 216 tests passed.

Failed tests

  • Generator tests/.NET: Failed (Execution failed with exit code 1)
  • DotNet tests: Failed (Execution failed with exit code 1)

Pipeline on Agent XAMBOT-1025.BigSur'
[AVFoundation] Make the notification change for xamcore 4 (#13134)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests iOS 🔥

Not enough free space in the host.

Pipeline on Agent
[AVFoundation] Make the notification change for xamcore 4 (#13134)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests iOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[AVFoundation] Make the notification change for xamcore 4 (#13134)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests tvOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[AVFoundation] Make the notification change for xamcore 4 (#13134)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests passed on macOS M1 - Mac Big Sur (11.5) ✅

Tests passed

All tests on macOS X M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
[AVFoundation] Make the notification change for xamcore 4 (#13134)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Tests failed on macOS Mac Mojave (10.14) ❌

Tests failed on Mac Mojave (10.14).

Failed tests are:

  • xammac_tests
  • monotouch-test

Pipeline on Agent
[AVFoundation] Make the notification change for xamcore 4 (#13134)

Please sign in to comment.