[msbuild] Only execute DetectDebugNetworkConfigurationTask for debug …

…builds (#10194) Not that it was very slow but it did make to the top 10 of the archive build I was debugging. Also reduce allocations in the task itself, for when it's needed.
xamarin · Dec 4, 2020 · cf5a229 · cf5a229 · xamarin-release-manager · Dec 4, 2020
1 parent 9e20285
commit cf5a229
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/msbuild/Xamarin.iOS.Tasks.Core/Tasks/DetectDebugNetworkConfigurationTaskBase.cs b/msbuild/Xamarin.iOS.Tasks.Core/Tasks/DetectDebugNetworkConfigurationTaskBase.cs
@@ -38,11 +38,10 @@ public abstract class DetectDebugNetworkConfigurationBase : XamarinTask
 
  public override bool Execute ()
  {
- var ips = new List<string> ();
-
  if (SdkIsSimulator) {
- ips.Add (IPAddress.Loopback.ToString ());
+ DebugIPAddresses = IPAddress.Loopback.ToString ();
  } else if (DebugOverWiFi) {
+ var ips = new List<string> ();
  string [] hosts = null;
 
  if (!string.IsNullOrEmpty (DebuggerHosts))
@@ -83,9 +82,9 @@ public override bool Execute ()
  Log.LogError (7002, null, MSBStrings.E7002);
  return false;
  }
- }
 
- DebugIPAddresses = string.Join (";", ips.ToArray ());
+ DebugIPAddresses = string.Join (";", ips);
+ }
 
  Log.LogTaskProperty ("DebugIPAddresses", DebugIPAddresses);
 

diff --git a/msbuild/Xamarin.iOS.Tasks.Core/Xamarin.iOS.Common.targets b/msbuild/Xamarin.iOS.Tasks.Core/Xamarin.iOS.Common.targets
@@ -899,7 +899,7 @@ Copyright (C) 2013-2016 Xamarin. All rights reserved.
  </EmbedMobileProvision>
  </Target>
 
- <Target Name="_DetectDebugNetworkConfiguration">
+ <Target Name="_DetectDebugNetworkConfiguration" Condition="'$(_BundlerDebug)' == 'true'">
  <DetectDebugNetworkConfiguration
  SessionId="$(BuildSessionId)"
  Condition="'$(IsMacEnabled)' == 'true'"