Skip to content

Commit

Permalink
[dotnet] We no longer need to add the entry assembly as a root assemb…
Browse files Browse the repository at this point in the history
…ly for the linker. (#17026)

It's automatically done in the linker's MSBuild logic.

Not only is it no longer necessary (hasn't been for a while), it'll be wrong
in .NET 8 after dotnet/linker#3124.
  • Loading branch information
rolfbjarne authored Dec 19, 2022
1 parent 65f362a commit e06f49d
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions dotnet/targets/Xamarin.Shared.Sdk.targets
Original file line number Diff line number Diff line change
Expand Up @@ -574,9 +574,6 @@
<TrimMode>copy</TrimMode> <!-- Don't use 'copyused', because that might still end up saving some assemblies, and if that's the platform assembly, it may break the partial static registrar -->
</ResolvedFileToPublish>

<!-- Mark our entry assembly as a root assembly. -->
<TrimmerRootAssembly Include="@(ResolvedFileToPublish)" Condition="'%(ResolvedFileToPublish.Filename)' == '$(AssemblyName)' And '%(ResolvedFileToPublish.Extension)' == '.dll'" />

<!--
pre-mark custom steps
-->
Expand Down

4 comments on commit e06f49d

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

Please sign in to comment.