Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to migrate items and properties from legacy Xamarin projects to .NET projects #11863

Closed
rolfbjarne opened this issue Jun 8, 2021 · 3 comments
Closed

Document how to migrate items and properties from legacy Xamarin projects to .NET projects #11863

rolfbjarne opened this issue Jun 8, 2021 · 3 comments
Assignees
@rolfbjarne
Labels
documentation The issue or pull request is about documentation dotnet An issue or pull request related to .NET (6) dotnet-pri2 .NET 6: want to have for stable release
Milestone
.NET 6

Comments

@rolfbjarne
Copy link
Member

rolfbjarne commented Jun 8, 2021 •
edited
Loading

See https://github.com/xamarin/xamarin-macios/wiki/Project-file-properties-dotnet-migration.

Upgrade assistant: https://github.com/dotnet/upgrade-assistant
@rolfbjarne rolfbjarne added documentation The issue or pull request is about documentation dotnet An issue or pull request related to .NET (6) dotnet-pri0 .NET 6: required for stable release labels Jun 8, 2021
@rolfbjarne rolfbjarne added this to the .NET 6 milestone Jun 8, 2021
@rolfbjarne rolfbjarne self-assigned this Aug 12, 2021
@rolfbjarne
Copy link
Member Author

@chamons in d7c2a45 you added the BundleDependentFiles item group as an input to the _CompileToNative tasks, but it doesn't seem like we use that item group anywhere else (nor adding to it) - was there any specific reason for this addition? Can it be removed? Or described/documented?

@chamons
Copy link
Contributor

chamons commented Sep 16, 2021

@rolfbjarne - I have honestly no clue. I think they can be removed based upon reviewing the PR.

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Sep 16, 2021
@rolfbjarne
[msbuild] Remove the BundleDependentFiles item group, it's not used.
2c67ebb 
The BundleDependentFiles item group was added as a target input some time ago [1],
but nothing ever adds to it, so it's always empty. Googling doesn't show anything
relevant either, so this looks like dead code we can remove.

[1]: d7c2a45
Ref: xamarin#11863 (comment)
@rolfbjarne rolfbjarne mentioned this issue Sep 16, 2021
Merged
rolfbjarne added a commit that referenced this issue Sep 17, 2021
@rolfbjarne
[msbuild] Remove the BundleDependentFiles item group, it's not used. (#…
d7651c0 
…12755)

The BundleDependentFiles item group was added as a target input some time ago [1],
but nothing ever adds to it, so it's always empty. Googling doesn't show anything
relevant either, so this looks like dead code we can remove.

[1]: d7c2a45
Ref: #11863 (comment)
@rolfbjarne rolfbjarne added dotnet-pri2 .NET 6: want to have for stable release and removed dotnet-pri0 .NET 6: required for stable release labels Sep 22, 2021
@rolfbjarne
Copy link
Member Author

This is mostly documented now, at least indirectly, in https://github.com/xamarin/xamarin-macios/wiki/Project-file-properties.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rolfbjarne rolfbjarne

Labels
documentation The issue or pull request is about documentation dotnet An issue or pull request related to .NET (6) dotnet-pri2 .NET 6: want to have for stable release
Projects
None yet
Milestone
.NET 6
Development

No branches or pull requests
2 participants
@rolfbjarne @chamons