Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NativeAOT: investigate default rooting behavior #18482

Closed
Tracked by #17339
rolfbjarne opened this issue Jun 21, 2023 · 1 comment
Closed
Tracked by #17339

NativeAOT: investigate default rooting behavior #18482

rolfbjarne opened this issue Jun 21, 2023 · 1 comment
Labels
enhancement The issue or pull request is an enhancement
Milestone
.NET 8

Comments

@rolfbjarne
Copy link
Member

Currently we're passing this to ILC:

<!-- Disable trimming by default (assemblies aren't trimmed unless they're marked IsTrimmable) -->
<IlcArg Include="--defaultrooting" />

we should look into whether this is needed.

Ref: #17374 (comment)
Ref:
@rolfbjarne rolfbjarne added the enhancement The issue or pull request is an enhancement label Jun 21, 2023
@rolfbjarne rolfbjarne added this to the .NET 8 milestone Jun 21, 2023
This was referenced Jun 21, 2023
Merged
Closed
@filipnavara filipnavara mentioned this issue Jul 3, 2023
Closed
@filipnavara filipnavara mentioned this issue Jul 17, 2023
Merged
dalexsoto pushed a commit that referenced this issue Jul 20, 2023
@filipnavara
Fix _DefaultLinkMode for NativeAOT. (#18560)
d635e6d 
Alternative to #18530, see
#18530 (comment)
Contributes to #18482
@ivanpovazan
Copy link
Contributor

Fixed via d635e6d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue or pull request is an enhancement
Projects
None yet
Milestone
.NET 8
Development

No branches or pull requests
2 participants
@rolfbjarne @ivanpovazan