Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Add xtro support for Mac Catalyst. Fixes #10214. #10289

Merged
merged 7 commits into from
Jan 11, 2021

Conversation

rolfbjarne
Copy link
Member

  • Add support to xtro for Mac Catalyst.
  • Add all the .todo files so that xtro doesn't fail.
  • Bump Objective-Sharpie.

Fixes #10214.

@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Dec 15, 2020
Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of files that should not be present in the PR, e.g. MacCatalyst-ruby.todo

IOW anything we don't support for macOS (or iOS) should not be committed as .todo (or even .ignore)

Beside the filtering things looks good :)

-exclude LDAP \
-exclude Python \
-exclude Quartz \
-exclude SecurityInterface \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are those exclusions to make sharpie work ?
because others do/should exists

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is to make sharpie work (the corresponding headers don't compile with Mac Catalyst).

@rolfbjarne
Copy link
Member Author

build

1 similar comment
@rolfbjarne
Copy link
Member Author

build

@monojenkins

This comment has been minimized.

@rolfbjarne
Copy link
Member Author

build

@monojenkins
Copy link
Collaborator

Build failure
Provisioning succeeded
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Test run failed 🔥

Test results

1 tests failed, 74 tests passed.

Failed tests

  • Xtro/Mac: Failed (Test run failed.)

@monojenkins
Copy link
Collaborator

Build failure
Provisioning succeeded
Build succeeded
API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
    ** Error: Working directory isn't clean:
    HEAD detached at 58e6632
    Untracked files:
    (use "git add ..." to include in what will be committed)
    tools/dotnet-linker/packages/
    
    nothing added to commit but untracked files present (use "git add" to track)
    Search for Comparing API & creating generator diff in the log to view the complete log.
Test run succeeded

@rolfbjarne
Copy link
Member Author

API comparison failure is unrelated.

@rolfbjarne rolfbjarne merged commit 22d65a5 into xamarin:main Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mac Catalyst: make xtro tests work
5 participants