-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] Add xtro support for Mac Catalyst. Fixes #10214. #10289
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of files that should not be present in the PR, e.g. MacCatalyst-ruby.todo
IOW anything we don't support for macOS (or iOS) should not be committed as .todo
(or even .ignore
)
Beside the filtering things looks good :)
-exclude LDAP \ | ||
-exclude Python \ | ||
-exclude Quartz \ | ||
-exclude SecurityInterface \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are those exclusions to make sharpie work ?
because others do/should exists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is to make sharpie work (the corresponding headers don't compile with Mac Catalyst).
build |
1 similar comment
build |
This comment has been minimized.
This comment has been minimized.
build |
Build failure Test results1 tests failed, 74 tests passed.Failed tests
|
Build failure |
API comparison failure is unrelated. |
Fixes #10214.