[runtime/dotnet] Call coreclr_initialize/monovm_initialize at startup. #10909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to call coreclr_initialize/monovm_initialize at startup, so do that. This is a partial implementation, in that we're not setting all the properties that we should, and also the PINVOKE_OVERRIDE callback is not doing everything it should either yet. Ref: xamarin#10504.
spouliot
approved these changes
Mar 18, 2021
dalexsoto
approved these changes
Mar 18, 2021
mandel-macaque
approved these changes
Mar 18, 2021
| @@ -6,6 +6,9 @@ | |||
| #ifndef __CORECLR_BRIDGE__ | |||
| #define __CORECLR_BRIDGE__ | |||
|
|
|||
| //#define LOG_CORECLR(...) | |||
| #define LOG_CORECLR(...) fprintf (__VA_ARGS__) | |||
There was a problem hiding this comment.
What's the diff between LOG_CORECLR and LOG_MONOVM ?
There was a problem hiding this comment.
There's no difference really, except that one is used in corelcr-bridge.m and the other in monovm-bridge.m.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to call coreclr_initialize/monovm_initialize at startup, so do that.
This is a partial implementation, in that we're not setting all the properties
that we should, and also the PINVOKE_OVERRIDE callback is not doing everything
it should either yet.
Ref: #10504.