Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[generate-type-forwarders] Fix issues with properties stubs #10941

Merged
merged 1 commit into from
Mar 24, 2021
Merged

[generate-type-forwarders] Fix issues with properties stubs #10941

merged 1 commit into from
Mar 24, 2021

Conversation

spouliot
Copy link
Contributor

Examples

  • Fix visibility, e.g. protected
-		public virtual System.IntPtr RawJointLandmarks {
+		protected virtual System.IntPtr RawJointLandmarks {
  • Remove non-visible properties, e.g. internal
-		public virtual System.IntPtr _AddressBook {
-			get { throw new global::System.PlatformNotSupportedException (global::Constants.UnavailableOnMacCatalyst); }
-			set { throw new global::System.PlatformNotSupportedException (global::Constants.UnavailableOnMacCatalyst); }
-		}
  • Fix abstract members
-public abstract ARSession Session { get; }
+public virtual ARSession Session { get; }

[generate-type-forwarders] Fix issues with properties stubs
294cc49 
Examples

* Fix visibility, e.g. `protected`

```diff
-		public virtual System.IntPtr RawJointLandmarks {
+		protected virtual System.IntPtr RawJointLandmarks {
```

* Remove non-visible properties, e.g. `internal`

```diff
-		public virtual System.IntPtr _AddressBook {
-			get { throw new global::System.PlatformNotSupportedException (global::Constants.UnavailableOnMacCatalyst); }
-			set { throw new global::System.PlatformNotSupportedException (global::Constants.UnavailableOnMacCatalyst); }
-		}
```

* Fix `abstract` members

```diff
-public abstract ARSession Session { get; }
+public virtual ARSession Session { get; }
```
@spouliot spouliot added the not-notes-worthy Ignore for release notes label Mar 23, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

🎉 All 182 tests passed 🎉

Pipeline on Agent XAMBOT-1102'

@spouliot spouliot merged commit 2b7dc07 into xamarin:main Mar 24, 2021
@spouliot spouliot deleted the gtf-properties branch March 24, 2021 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@stephen-hawley stephen-hawley stephen-hawley approved these changes

Assignees
No one assigned
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spouliot @vs-mobiletools-engineering-service2 @dalexsoto @rolfbjarne @stephen-hawley